Remove SoftReferences from StreamInput/StreamOutput #6208
Conversation
|
I've actually been looking into GC issues lately on my cluser. Soft references account for a pretty small amount of the young gen pause time. Weak references account for about 1/8th of though. Still, no reason not to do this. |
|
Why does StreamOutput write with standard UTF-8 and StreamInput read with modified UTF-8? These are incompatible for some unicode characters... |
|
@rmuir wait that is completely unrelated to this issue no? Can you open a followup? |
@rmuir that is not entirely true the write part that I fixed is |
|
your right, as long as writeText is always paired with readText and vice versa, it will be ok. but this is dangerous, because bugs could sit latent (and simple tests would not find them). so some care should be taken to reduce this risk... |
We try to reuse character arrays and UTF8 writers with softreferences. SoftReferences have negative impact on GC and should be avoided in general. Yet in this case it can simply replaced with a per-stream Bytes/CharsRef that is thread local and has the same lifetime as the stream.
|
+1, it cleans the code. I am less concerned about the SoftReference aspect, since its a static thread local. |
We try to reuse character arrays and UTF8 writers with softreferences.
SoftReferences have negative impact on GC and should be avoided in
general. Yet in this case it can simply replaced with a per-stream
Bytes/CharsRef that is thread local and has the same lifetime as the
stream.