Don't report terms as live if all it's docs are filtered out #6221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good - the only possible side effect is in FilterableTermsEnum.seekExact() any IOException will now leave currentDocFreq as prior value whereas before it would set NOT_FOUND. I don't think we define expected behaviour or rely on it in the event of IOException so should be fine. |
IMO what we see now is the right behavior. if we see and exception we don't change the internal state. |
|
Makes sense |
FilterableTermsEnum allows to filter stats by supplying per segment bits. Today if all docs are filtered out the term is still reported as live but shouldn't. Relates to elastic#6211
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FilterableTermsEnum allows to filter stats by supplying per segment
bits. Today if all docs are filtered out the term is still reported as
live but shouldn't.
Relates to #6211