Test: Add dummy docs injection to indexRandom #6235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We currently ask `MatchDocIdSet#matchDoc(int)` before consulting the accept docs. This can also have a negative performance impact since `matchDoc(int)` calls might be way more expensive than acceptDocs calls. Closes elastic#6234
This commit add `dummy docs` to `ElasticsearchIntegrationTest#indexRandom`. It indexes document with an empty body into the indices specified by the docs and deletes them after all docs have been indexed. This produces gaps in the segments and enforces usage of accept docs on lower levels to ensure the features work with delete documents as well.
|
I really like that change! |
|
@jpountz ;) |
clintongormley
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds
dummy docstoElasticsearchIntegrationTest#indexRandom.It indexes document with an empty body into the indices specified by the docs
and deletes them after all docs have been indexed. This produces gaps in
the segments and enforces usage of accept docs on lower levels to ensure
the features work with delete documents as well.