Create only one MLT query per field for all queried items #6404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eried items. Previously, one MLT query per field was created for each item. One issue with this method is that the maximum number of selected terms was equal to the number of items times 'max_query_terms'. Instead, users should have direct control over the maximum number of selected terms allowed, regardless of the number of queried items. Another issue related to the previous method is that it could lead to the selection of rather uninteresting terms, that because they were found in a particular queried item. Instead, this new procedure enforces the selection of interesting terms across ALL items, not within each item. This could lead to search results where the best matching items share commonalities amongst the best characteristics of all the items.
|
Could we try to keep LikeText immutable? It doesn't feel right to me to modify in-place the instances returned by Otherwise I think it is a nice change! |
|
LGTM |
alexksikes
added a commit
that referenced
this pull request
Jun 12, 2014
…eried items. Previously, one MLT query per field was created for each item. One issue with this method is that the maximum number of selected terms was equal to the number of items times 'max_query_terms'. Instead, users should have direct control over the maximum number of selected terms allowed, regardless of the number of queried items. Another issue related to the previous method is that it could lead to the selection of rather uninteresting terms, that because they were found in a particular queried item. Instead, this new procedure enforces the selection of interesting terms across ALL items, not within each item. This could lead to search results where the best matching items share commonalities amongst the best characteristics of all the items. Closes #6404
alexksikes
added a commit
to alexksikes/elasticsearch
that referenced
this pull request
Jun 12, 2014
…eried items. Previously, one MLT query per field was created for each item. One issue with this method is that the maximum number of selected terms was equal to the number of items times 'max_query_terms'. Instead, users should have direct control over the maximum number of selected terms allowed, regardless of the number of queried items. Another issue related to the previous method is that it could lead to the selection of rather uninteresting terms, that because they were found in a particular queried item. Instead, this new procedure enforces the selection of interesting terms across ALL items, not within each item. This could lead to search results where the best matching items share commonalities amongst the best characteristics of all the items. Closes elastic#6404
clintongormley
changed the title
clintongormley
added
:Search/Search
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, one MLT query per field was created for each item. One issue with
this method is that the maximum number of selected terms was equal to the
number of items times 'max_query_terms'. Instead, users should have direct control
over the maximum number of selected terms allowed, regardless of the number of
queried items.
Another issue related to the previous method is that it could lead to the
selection of rather uninteresting terms, that because they were found in a
particular queried item. Instead, this new procedure enforces the selection of
interesting terms across ALL items, not within each item. This could lead to
search results where the best matching items share commonalities amongst the
best characteristics of all the items.