Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix cardinality aggregation when doc values field is empty #6413

Merged
merged 2 commits into from Jun 10, 2014
Merged

Fix cardinality aggregation when doc values field is empty #6413

merged 2 commits into from Jun 10, 2014

Conversation

martijnvg
Copy link
Member

In case a doc values field doesn't have values all the time the cardinality aggregation can fail with a ArrayIndexOutOfBoundsException.

@s1monw
Copy link
Contributor

s1monw commented Jun 6, 2014

LGTM

@s1monw s1monw removed the review label Jun 6, 2014
@jpountz
Copy link
Contributor

jpountz commented Jun 9, 2014

LGTM

@martijnvg
Fielddata: EmptyOrdinals#getMaxOrd() should return 0 instead of 1, si…
e15d2e2 
…nce ordinals are zero based since elastic#5871.
@martijnvg
Aggregations: if maxOrd is 0 then use noop collector
38be1e0 
Before the OrdinalsCollector was used and this leads to a ArrayIndexOutOfBoundsException

Closes elastic#6413
martijnvg added a commit that referenced this pull request Jun 10, 2014
@martijnvg
Aggregations: if maxOrd is 0 then use noop collector
66ae6cf 
Before the OrdinalsCollector was used and this leads to a ArrayIndexOutOfBoundsException

Closes #6413
martijnvg added a commit that referenced this pull request Jun 10, 2014
@martijnvg
Aggregations: if maxOrd is 0 then use noop collector
20278f4 
Before the OrdinalsCollector was used and this leads to a ArrayIndexOutOfBoundsException

Closes #6413
@martijnvg martijnvg merged commit 38be1e0 into elastic:master Jun 10, 2014
@clintongormley clintongormley changed the title Cardinality aggregation fails in case of empty doc values field Aggregations: Fix cardinality aggregation when doc values field is empty Jul 9, 2014
@martijnvg martijnvg deleted the bug/cardinality_agg_empty_field_in_segment branch May 18, 2015 23:31
@clintongormley clintongormley changed the title Aggregations: Fix cardinality aggregation when doc values field is empty Fix cardinality aggregation when doc values field is empty Jun 7, 2015
mute pushed a commit to mute/elasticsearch that referenced this pull request Jul 29, 2015
@martijnvg
Aggregations: if maxOrd is 0 then use noop collector
d150856 
Before the OrdinalsCollector was used and this leads to a ArrayIndexOutOfBoundsException

Closes elastic#6413
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
:Analytics/Aggregations Aggregations >bug v1.2.2 v1.3.0 v2.0.0-beta1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@martijnvg @s1monw @jpountz @clintongormley