Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build: Check for tabs and nocommits in the code on validate #6474

Merged
merged 1 commit into from Jun 12, 2014
Merged

Build: Check for tabs and nocommits in the code on validate #6474

merged 1 commit into from Jun 12, 2014

Conversation

s1monw
Copy link
Contributor

@s1monw s1monw commented Jun 12, 2014

This commit adds checks for nocommit and tabs in the source code.
The task is executed during the validate phase and can be disabled via
-Dvalidate.skip

@s1monw s1monw added review and removed test labels Jun 12, 2014
@s1monw
Copy link
Contributor Author

s1monw commented Jun 12, 2014

Will this fail if the source contains \t inside a string constant? Or maybe we just disallow that too...

no it will not fail - we use that often like in the CAT API

@s1monw
Copy link
Contributor Author

s1monw commented Jun 12, 2014

Can we also check e.g. .py, .xml, .pl, .txt (others?)? Or maybe invert the check to exclude known false positives...

I added a new commit

@mikemccand
Copy link
Contributor

Thanks Simon, LGTM

@s1monw
[BUILD] Check for tabs and nocommits in the code on validate
5575ba1 
This commit adds checks for nocommit and tabs in the source code.
The task is executed during the validate phase and can be disabled via
`-Dvalidate.skip`
@s1monw s1monw removed the review label Jun 12, 2014
@s1monw s1monw merged commit 5575ba1 into elastic:master Jun 12, 2014
@clintongormley clintongormley changed the title [BUILD] Check for tabs and nocommits in the code on validate Build: Check for tabs and nocommits in the code on validate Jul 16, 2014
@clintongormley clintongormley added :Delivery/Build Build or test infrastructure and removed >enhancement labels Jun 7, 2015
@mark-vieira mark-vieira added the Team:Delivery Meta label for Delivery team label Nov 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
:Delivery/Build Build or test infrastructure Team:Delivery Meta label for Delivery team v1.3.0 v2.0.0-beta1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@s1monw @mikemccand @clintongormley @mark-vieira