Moved BucketsAggregator#docCounts field to IntArray #6529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| return asc ? Long.compare(v1, v2) : Long.compare(v2, v1); | ||
| int v1 = ((SingleBucketAggregator) aggregator).bucketDocCount(((InternalTerms.Bucket) o1).bucketOrd); | ||
| int v2 = ((SingleBucketAggregator) aggregator).bucketDocCount(((InternalTerms.Bucket) o2).bucketOrd); | ||
| return asc ? Integer.compare(v1, v2) : Integer.compare(v2, v1); |
There was a problem hiding this comment.
Since counts are positive, I think you can make it faster by computing int mul = asc ? 1 : -1 up-front and returning mul * (v1 - v2) in compare?
There was a problem hiding this comment.
Make sense, I'll change
|
LGTM |
… because a shard can't hold more than Integer.MAX_VALUE a LongArray just takes unnecessary space. Closes elastic#6529
martijnvg
added a commit
that referenced
this pull request
Jun 17, 2014
… because a shard can't hold more than Integer.MAX_VALUE a LongArray just takes unnecessary space. Closes #6529
spinscale
changed the title
clintongormley
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.