Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Groovy sandboxing for GString-based method invocation #6596

Merged
merged 1 commit into from Jun 25, 2014
Merged

Add Groovy sandboxing for GString-based method invocation #6596

merged 1 commit into from Jun 25, 2014

Conversation

dakrone
Copy link
Member

@dakrone dakrone commented Jun 23, 2014

This forbids things like:

obj."${'get' + 'Class'}"()."${'getDeclared' + 'Method'}"("myPrivateMethod")."${'set' + 'Accessible'}"(true)

@kimchy
Copy link
Member

kimchy commented Jun 23, 2014

LGTM

@s1monw
Copy link
Contributor

s1monw commented Jun 24, 2014

+1

@s1monw s1monw removed the review label Jun 24, 2014
@dakrone dakrone merged commit 47856ec into elastic:master Jun 25, 2014
@clintongormley clintongormley changed the title Add Groovy sandboxing for GString-based method invocation Scripting: Add Groovy sandboxing for GString-based method invocation Jul 16, 2014
@dakrone dakrone deleted the feature/groovy/additional-sandboxing branch September 9, 2014 13:47
@clintongormley clintongormley added the :Core/Infra/Scripting Scripting abstractions, Painless, and Mustache label Jun 7, 2015
@clintongormley clintongormley changed the title Scripting: Add Groovy sandboxing for GString-based method invocation Add Groovy sandboxing for GString-based method invocation Jun 7, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
:Core/Infra/Scripting Scripting abstractions, Painless, and Mustache >enhancement v1.3.0 v2.0.0-beta1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dakrone @kimchy @s1monw @clintongormley