Cancel recovery if shard on the target node closes during recovery operation #6645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM - I would change the title of the PR to indicate this is about closing the shard on the target node. I was thinking how we can test it. Maybe a test that issues a relocation command, then overrides it with an allocation filtering rule. This will at least make sure the code kicks in every once in a while |
martijnvg
changed the title
|
@bleskes I added a test that is likely to cancel an ongoing recovery. |
|
@martijnvg thx. Left some comments on the commit (sorry, notice too late it's not the PR) |
|
|
||
| ClusterStateResponse stateResponse = client().admin().cluster().prepareState().get(); | ||
| String blueNodeId = null; | ||
| for (DiscoveryNode discoveryNode : stateResponse.getState().nodes()) { |
There was a problem hiding this comment.
Nit picky: if we capture the node name from the start async we can do internalCluster().getInstance(DiscoveryNode.class, blueNodeName).id()
|
@bleskes Good points, I applied the feedback. |
|
LGTM! |
…e recovery operations. Closes elastic#6645
martijnvg
added a commit
that referenced
this pull request
Jul 1, 2014
…e recovery operations. Closes #6645
martijnvg
changed the title
|
Does this solve issue #6430 ? |
clintongormley
changed the title
clintongormley
added
the
:Distributed/Recovery
clintongormley
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On the target side if the shard closes while recovery is in progress (e.g. files being transferred), the recovery operation should be cancelled.