Ensure selection of best terms is indeed O(n) #6657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I left a comment on the lucene issue. |
| int x; | ||
|
|
||
| Int() { | ||
| x = 1; |
There was a problem hiding this comment.
Minor, but both places that use this could avoid assigning a value by always using the contents of else block if this were initialized to 0.
Int cnt = termFreqMap.get(term);
if (cnt == null) {
cnt = new Int();
termFreqMap.put(term, cnt);
}
cnt.x += freq;
There was a problem hiding this comment.
Thanks for the comment, I'm thinking that out of clarity we can keep the else block.
|
I committed this to lucene will be in 4.10 |
Previously the size of the priority queue was wrongly set to the total number of terms. Instead, it should be set to 'maxQueryTerms'. This makes the selection of best terms O(n), instead of O(n*log(n)). Jira patch: https://issues.apache.org/jira/browse/LUCENE-5795 Closes elastic#6657
alexksikes
added a commit
that referenced
this pull request
Jul 11, 2014
Previously the size of the priority queue was wrongly set to the total number of terms. Instead, it should be set to 'maxQueryTerms'. This makes the selection of best terms O(n), instead of O(n*log(n)). Jira patch: https://issues.apache.org/jira/browse/LUCENE-5795 Closes #6657
clintongormley
changed the title
clintongormley
changed the title
clintongormley
added
:Search/Search
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the size of the priority queue was wrongly set to the total number
of terms. Instead, it should be set to 'maxQueryTerms'. This makes the
selection of best terms O(n), instead of O(n*log(n)).
Jira patch: https://issues.apache.org/jira/browse/LUCENE-5795