Test: Prevent usage of System Properties in the InternalTestCluster #6663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| public static String nodeMode() { | ||
| Settings build = ImmutableSettings.builder() | ||
| .put("node.local", System.getProperty("es.node.local", "true")) // default to local | ||
| .put("es.node.mode", System.getProperty("es.node.local", "local")).build(); |
There was a problem hiding this comment.
Also I think you should take out the es prefix from the key that you use to put?
|
Left a few comments @s1monw ;) |
|
@javanna I pushed a new commit |
|
LGTM |
All settings should be passes as settings and the enviroment should not influence the test cluster settings. The settings we care about ie. `es.node.mode` and `es.logger.level` should be passed via settings. This allows tests to override these settings if they for instance need `network` transport to operate at all. Closes elastic#6663
|
LGTM |
s1monw
added a commit
that referenced
this pull request
Jul 1, 2014
All settings should be passes as settings and the enviroment should not influence the test cluster settings. The settings we care about ie. `es.node.mode` and `es.logger.level` should be passed via settings. This allows tests to override these settings if they for instance need `network` transport to operate at all. Closes #6663
|
just in time @spinscale |
clintongormley
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All settings should be passes as settings and the enviroment should not
influence the test cluster settings. The settings we care about ie.
es.node.modeandes.logger.levelshould be passed via settings.This allows tests to override these settings if they for instance need
networktransport to operate at all.