Handle ConnectionTransportException during a Master/Node fault detection ping during Discovery #6686
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t detection ping Both the Master and Node fault detection register themselves to be notified when a node disconnects to be able to respond to it accordingly. As such, when a ConnectionTransportException was raised on a ping request, it was not handled it as it is already handled somewhere else. However, this does introduce a racing condition, if the disconnect happen during a period where there is no current master (minimum_master_node breach) at which time the fault detection is not active. This case we will only discover the disconnect error during the ping request, so we have to respond accordingly.
| NodeFD nodeFD = nodesFD.get(node); | ||
| if (nodeFD != null) { | ||
| if (!nodeFD.running) { | ||
| return; | ||
| } | ||
| if (exp instanceof ConnectTransportException) { | ||
| // ignore this one, we already handle it by registering a connection listener |
There was a problem hiding this comment.
with this change, this comment is obsolete.
There was a problem hiding this comment.
yes. left overs. will remove.
|
Left one small comment, other than that LGTM. |
|
same here, LGTM |
bleskes
changed the title
bleskes
added a commit
that referenced
this pull request
Jul 2, 2014
…fault detection ping Both the Master and Node fault detection register themselves to be notified when a node disconnects to be able to respond to it accordingly. As such, when a ConnectionTransportException was raised on a ping request, it was not handled as it is already handled somewhere else. However, this does introduce a racing condition, if the disconnect happen during a period where there is no current master (minimum_master_node breach) at which time the fault detection is not active. In this case, we will only discover the disconnect error during the ping request, so we have to respond accordingly. Closes #6686
bleskes
added a commit
that referenced
this pull request
Jul 3, 2014
…sconnects The change introduced in #6686 checks for ConnectionTransportException during pinging. However, transport layer wraps it in SendRequestTransportException
bleskes
added a commit
that referenced
this pull request
Jul 3, 2014
…sconnects The change introduced in #6686 checks for ConnectionTransportException during pinging. However, transport layer wraps it in SendRequestTransportException
clintongormley
changed the title
clintongormley
added
the
:Distributed/Discovery-Plugins
clintongormley
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both the Master and Node fault detection register themselves to be notified when a node disconnects to be able to respond to it accordingly. As such, when a ConnectionTransportException was raised on a ping request, it was not handled as it is already handled somewhere else. However, this does introduce a racing condition, if the disconnect happen during a period where there is no current master (minimum_master_node breach) at which time the fault detection is not active. In this case, we will only discover the disconnect error during the ping request, so we have to respond accordingly.