Check for index blocks against concrete indices on master operations #6694

javanna · 2014-07-02T20:10:37Z

Some master operations require to check for index blocks, done by overriding TransportMasterNodeOperationAction#checkBlock. We need to make sure though that the check is done against concrete indices, otherwise we might not get blocks back altough there are.

For instance you can currently delete a read-only index using an alias that points to it, or using the _all alias:

curl -XPUT localhost:9200/foo

curl -XPUT 'localhost:9200/foo/_settings' -d '
{
    "index" : {
        "blocks.read_only" : true
    } }
'

curl -XDELETE localhost:9200/foo
#{"error":"ClusterBlockException[blocked by: [FORBIDDEN/5/index read-only (api)];]","status":403}

curl -XDELETE localhost:9200/_all
#{"acknowledged":true}

The problem seems to affect the following apis:

delete index
delete mapping
types exists
indices exists
open index
close index

The text was updated successfully, but these errors were encountered:

…crete ones, and make sure check blocks is executed on concrete indices Concrete indices is now called multiple times when needed instead of changing what's inside the incoming request with the concrete indices. Ideally we want to keep the original aliases or indices or wildcard expressions in the request. Also made sure that the check blocks is done against the concrete indices, which wasn't the case for delete index, delete mapping, open index, close index, types exists and indices exists. Closes elastic#6694 Closes elastic#6777

…e ones, and make sure check blocks is executed on concrete indices Concrete indices is now called multiple times when needed instead of changing what's inside the incoming request with the concrete indices. Ideally we want to keep the original aliases or indices or wildcard expressions in the request. Also made sure that the check blocks is done against the concrete indices, which wasn't the case for delete index, delete mapping, open index, close index, types exists and indices exists. Closes #6694 Closes #6777

javanna added the bug label Jul 2, 2014

javanna self-assigned this Jul 2, 2014

javanna added v1.3.0 labels Jul 2, 2014

javanna closed this as completed in 8dedbd0 Jul 8, 2014

clintongormley changed the title ~~Check for index blocks against concrete indices on master operations~~ Internal: Check for index blocks against concrete indices on master operations Jul 16, 2014

clintongormley added the :Cluster label Jun 7, 2015

clintongormley changed the title ~~Internal: Check for index blocks against concrete indices on master operations~~ Check for index blocks against concrete indices on master operations Jun 7, 2015

clintongormley added :Distributed/Distributed A catch all label for anything in the Distributed Area. If you aren't sure, use this one. and removed :Cluster labels Feb 13, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Check for index blocks against concrete indices on master operations #6694

Check for index blocks against concrete indices on master operations #6694

javanna commented Jul 2, 2014

Check for index blocks against concrete indices on master operations #6694

Check for index blocks against concrete indices on master operations #6694

Comments

javanna commented Jul 2, 2014