Set a default of 5m to recover_after_time
when any of the expected*Nodes
is set
#6742
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
recovery_after_time
tells the gateway to wait before starting recovery from disk. The goal here is to allow for more nodes to join the cluster and thus not start potentially unneeded replications. TheexpectedNodes
setting (and friends) tells the gateway when it can start recovering even if therecover_after_time
has not yet elapsed. However,expectedNodes
is useless if one doesn't setrecovery_after_time
. This commit changes that by setting a sensible default of 5m forrecover_after_time
if aexpectedNodes
setting is present.