Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't attempt to start or fail shard if no master node can be found #6841

Merged
merged 1 commit into from Jul 13, 2014
Merged

Don't attempt to start or fail shard if no master node can be found #6841

merged 1 commit into from Jul 13, 2014

Conversation

martijnvg
Copy link
Member

No description provided.

bleskes
bleskes reviewed Jul 13, 2014
View reviewed changes
src/main/java/org/elasticsearch/cluster/action/shard/ShardStateAction.java
@@ -79,6 +79,7 @@ public void shardFailed(final ShardRouting shardRouting, final String indexUUID,
DiscoveryNode masterNode = clusterService.state().nodes().masterNode();
if (masterNode == null) {
logger.debug("can't send shard failed for {}. no master known.", shardRouting);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should change this to a warning level log (without the return it would be logged as warning in the overloaded shardFailed message)

@bleskes
Copy link
Contributor

bleskes commented Jul 13, 2014

LGTM. Left one comment regarding logging levels

@martijnvg martijnvg merged commit af38b9f into elastic:master Jul 13, 2014
martijnvg added a commit that referenced this pull request Jul 13, 2014
@martijnvg
Core: Added missing return statements.
325da82 
Closes #6841
@jpountz jpountz removed the review label Jul 16, 2014
@martijnvg martijnvg changed the title Added missing return statements Core: Added missing return statements Jul 16, 2014
@martijnvg martijnvg changed the title Core: Added missing return statements Core: Don't fail shard if no master node can be found Jul 16, 2014
@martijnvg martijnvg changed the title Core: Don't fail shard if no master node can be found Core: Don't attempt to start or fail shard if no master node can be found Jul 16, 2014
@clintongormley clintongormley changed the title Core: Don't attempt to start or fail shard if no master node can be found Resiliency: Don't attempt to start or fail shard if no master node can be found Jul 16, 2014
@martijnvg martijnvg deleted the missing_return_statements branch May 18, 2015 23:31
@clintongormley clintongormley changed the title Resiliency: Don't attempt to start or fail shard if no master node can be found Don't attempt to start or fail shard if no master node can be found Jun 7, 2015
@clintongormley clintongormley added :Distributed/Distributed A catch all label for anything in the Distributed Area. If you aren't sure, use this one. and removed :Cluster labels Feb 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
:Distributed/Distributed A catch all label for anything in the Distributed Area. If you aren't sure, use this one. >enhancement resiliency v1.3.0 v2.0.0-beta1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@martijnvg @bleskes @clintongormley @jpountz