Fix infinite loop in the histogram reduce logic. #7022
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The histogram reduce method can run into an infinite loop if the Rounding.nextRoundingValue value is buggy, which happened to be the case for DayTimeZoneRoundingFloor. DayTimeZoneRoundingFloor is fixed, and the histogram reduce method has been changed to fail instead of running into an infinite loop in case of a buffy nextRoundingValue impl. Close elastic#6965
| @@ -162,7 +162,7 @@ public long valueForKey(long time) { | |||
|
|
|||
| @Override | |||
| public long nextRoundingValue(long value) { | |||
| return unit.field().roundCeiling(value + 1); | |||
| return unit.field().getDurationField().add(value, 1); | |||
There was a problem hiding this comment.
does it make sense to assign this unit.field().getDurationField() to a field?
|
I think this LGTM - left a minor comment |
|
@s1monw I pushed a commit that should address your comment. |
clintongormley
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The histogram reduce method can run into an infinite loop if the
Rounding.nextRoundingValue value is buggy, which happened to be the case for
DayTimeZoneRoundingFloor.
DayTimeZoneRoundingFloor is fixed, and the histogram reduce method has been
changed to fail instead of running into an infinite loop in case of a buffy
nextRoundingValue impl.
Close #6965