Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Protect against overwriting existing packs/snapshots #57

Open
peterwaller-arm opened this issue Nov 18, 2021 · 0 comments
Open

Protect against overwriting existing packs/snapshots #57

peterwaller-arm opened this issue Nov 18, 2021 · 0 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@peterwaller-arm
Copy link
Contributor

Right now, if you create a pack or a snapshot, we don't check for an already existing one. The idea is to use the AtomicFileCreate API to check for the existence without a TOCTOU bug since it may take some time to create an output.

So the task is to wire this together, or alternatively implement a straightforward fs::exists check.

We should also provide a flag to overwrite (--force?), since I have found this misfeature somewhat useful during development.
@peterwaller-arm peterwaller-arm added good first issue Good for newcomers help wanted Extra attention is needed labels Nov 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@peterwaller-arm