Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

elfshaker looses executable flag on files #93

Open
marxin opened this issue Sep 15, 2022 · 6 comments
Open

elfshaker looses executable flag on files #93

marxin opened this issue Sep 15, 2022 · 6 comments
Milestone

Comments

@marxin
Copy link

marxin commented Sep 15, 2022

$ echo XXX > A && chmod 755 A
$ ls -l A
-rwxr-xr-x 1 marxin users 4 Sep 15 12:43 A
$ elfshaker store one
$ rm A
$ elfshaker extract one --reset
A 	1 files
D 	0 files
M 	0 files
Extracted 'loose/one:one'
$ ls -l A
-rw-r--r-- 1 marxin users 4 Sep 15 12:44 A
@marxin
Copy link
Author

marxin commented Sep 15, 2022

@Mistuke

@peterwaller-arm
Copy link
Contributor

This is #13, but happy to leave this open. It's tricky since it will require extra information in the index and a new index format. Definitely something we want to address I think.

@marxin
Copy link
Author

marxin commented Sep 16, 2022

Maybe you can sneak in a few bits in the current index format. What do you think? Is the problem related only to the executable flag, or the flags as well?

@peterwaller-arm
Copy link
Contributor

It's all of the mode bits. Yes, I think the information can be put in there in principle, with effort. Can't promise a timescale at the moment, apologies.

@peterwaller-arm
Copy link
Contributor

I have a draft PR to implement this at #107.

@peterwaller-arm peterwaller-arm added this to the 1.0.0-rc1 milestone Aug 21, 2023
@peterwaller-arm
Copy link
Contributor

This should be fixed on master and we're preparing to make a release before too long, sorry for the wait, it has been a spare time project :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants