Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VAT is possibly incorrect when using prewarmer #23

Open
peterjaap opened this issue Nov 15, 2018 · 0 comments
Open

VAT is possibly incorrect when using prewarmer #23

peterjaap opened this issue Nov 15, 2018 · 0 comments

Comments

@peterjaap
Copy link
Contributor

I noticed that the ex VAT prices in the prewarmer-generated JSON will always use the tax percentage of the base store. This also (like prices themselves and attribute option value translations) does not take the storeview in account when run through the bin/magento console command.

This means that the ex VAT prices are possibly incorrect (if a the storeview uses a different tax percentage than the default storeview). However, since the JSON is only used on the product page for display purposes, this only poses an issue when you show excluding VAT prices on the frontend.

I haven't had time to fix this yet so this is just a placeholder issue for when I (or somebody else) encounters this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant