Integration hooks not detected.

[tinoest]

In the latest development version of Elkarte the integration hooks for TinyPortal are not detected.

I think it is due to the file only being read in for the first hook. As adding an else to the if/elseif block results in it falling through to there. I would expect the preg_match to catch it.

Elkarte/sources/subs/AddonSettings.subs.php

Line 82 in 6d3b525

$fp = fopen($file['dir'] . '/' . $file['name'], 'rb');

[Spuds]

Are you seeing that in the maintenance -> integration hooks function ?

[tinoest]

Sorry it was this path.

index.php?action=admin;area=maintain;sa=hooks;

[emanuele45]

Hey, long time no see... :-\
I was wondering: does this page really help in any way?
I mean, IIRC the management page was added just as a way to reassure some people that hooks were not evil when "some people" at the times of SMF 2.1-alpha were raising all sort of conspiracy theories about presence of hooks and possibilities of being hacked and all sort of stuff.
I always found it rather tricky to maintain and actually a potential problem in exposing internal functioning of hooks that for the average admin would have been pretty tricky if tinkered with. 🤷‍♂️
As usual, I start suggesting to kill stuff... 😆

[Spuds]

I'm never opposed to removing stuff, especially when it does not provide a clear benefit. Oh hooks are are evil, hard editing FTW