Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Elkarte install issue w/current GitHub - Remove extension from existing smiley filenames #3684

Open
sbulen opened this issue Jan 15, 2023 · 9 comments
Labels

Comments

@sbulen
Copy link
Contributor

sbulen commented Jan 15, 2023

Describe the bug
With the current GitHub code, a fresh install doesn't complete, you get:

Error!
Error retrieving information on step: Remove extension from existing smiley filenames ... (Item: 13)

ElkArte info
4. What version of PHP are you running? 8.1.2
5. MySQL or PostgreSQL and what version? MySQL 8.0.20
6. Running on a wamp

To Reproduce
Steps to reproduce the behavior:

  1. Copy current GitHub code to a new directory
  2. Attempt an install

Screenshots
image

Additional context
The install steps appear to work, it is a subsequent upgrade step that fails.

1.1.8 wouldn't install in this environment either - different error (Table 'elkarte.elkarte_settings' doesn't exist ).

@Spuds
Copy link
Contributor

Spuds commented Jan 15, 2023

Thanks for the report.

Just for my clarity, by current code you mean from the development branch and you attempted to upgrade a V1.1.x forum to 2.x or was this an older 1.1.x branch that you attempted to upgrade to 1.1.8?

The "fresh" 1.1.8 error is strange, seems like an compatibility with wamp but I'll check fresh installs on a couple of *nix setups as well.

@sbulen
Copy link
Contributor Author

sbulen commented Jan 15, 2023

Yes, using the dev branch for 2.0.

In both cases (1.1.8 & 2.0), there were no pre-existing forums, they were installs. I haven't been able to complete an install.

@Spuds
Copy link
Contributor

Spuds commented Jan 15, 2023

Thanks for the details. Strange that the screenshot shows upgrade and not install, looks like its jumping to the wrong script on wamp. The 2.0 install fail is not to surprising, the version on the site was hand installed. I'll take a look at both, even if that means I have to install wamp 😭 😭

@sbulen
Copy link
Contributor Author

sbulen commented Jan 15, 2023

It completes an install process, then immediately starts an upgrade. I thought that was deliberate - sounds like the issue is the upgrade step isn't necessary?

If you like, I'll do a separate writeup on 1.1.8, the symptoms are different.

@sbulen
Copy link
Contributor Author

sbulen commented Jan 15, 2023

FYI, I just tried both on linux & got the same results.

My linux environment is a bit different: MySQL 5.7, PHP 8.1.14

I wonder if I'm doing something wrong, e.g., default collations, php settings, etc. I couldn't find a 'minimum requirements' post on the elkarte forum. (And fyi, I'm not receiving registration emails.)

@Spuds
Copy link
Contributor

Spuds commented Jan 15, 2023

The upgrade is not necessary. Its supposed to detect that no upgrade is available, should the install directory still be present, , but its super janky. Just rename the install directory or add $ignore_install_dir = true; define('IGNORE_INSTALL_DIR', 1); to the settings.php file to avoid that.

I did get xamp installed, it creates the db but not the tables and then fails ... have not looked at why. I'm going to "guess" that is a 8.1 issue. I've been trying to get 1.1.9 out which address the various 8.1 issues but things just don't always go as expected.

(And fyi, I'm not receiving registration emails.)

Check you spam folder (sorry, had to say it 😇 ) I do not have access to the mail.log to check if there is a rejection from pacbell, so I just went ahead and approved it.

@sbulen
Copy link
Contributor Author

sbulen commented Jan 15, 2023

Confirmed - things work much better on php8.0 vs php8.1.

On 1.1.8, it creates the tables & completes properly with php8.0. Immediately after installation, it complains a file in the install dir is missing (which makes sense given there is no install dir...). I just ignored that error & everything is working fine now.

On 2.0, I just ignored the errors, removed the install dir, & it is also working fine.

So, yes, php8.1 is an issue. And yes, a little jankiness in the install/upgrade detection for both 1.1.8 & 2.0.

@sbulen
Copy link
Contributor Author

sbulen commented Jan 15, 2023

And, yes, it would be REALLY REALLY nice if they stopped rewriting php every few months. 🙄

@Spuds
Copy link
Contributor

Spuds commented Jan 15, 2023

This is php 8.1 changing mysql to throw exceptions such that the @ no longer works. Been so long ago I forgot about that. A quick fix for the 1.1.8 installer on 8.1 would be to add

		if ($db_type === 'mysql')
			mysqli_report(MYSQLI_REPORT_OFF);

to the CommonCode.php file in the install directory, in the load_database function, just after the $db_connection line.

And, yes, it would be REALLY REALLY nice if they stopped rewriting php every few months. 🙄

Which reminds me, I need to start testing on 8.2 (especially since 7.4 went essentially eol in December), which means more hosts are going to force push to the 8.x branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants