Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use apollo-client without apollo-link-http #148

Open
tchak opened this issue Jul 12, 2018 · 2 comments
Open

Use apollo-client without apollo-link-http #148

tchak opened this issue Jul 12, 2018 · 2 comments

Comments

@tchak
Copy link

tchak commented Jul 12, 2018

I am implementing my own link (not based on http). If I exclude apollo-link-http from packages (to save some space) the apollo service will crash because unable to load apollo-link-http. Would you accept a PR to have a BaseApolloService without apollo-link-http (and maybe without cache) from which ApolloService will inherit and from which users can inherit in advanced cases?

@bgentry
Copy link
Member

bgentry commented Jul 12, 2018

Yes, the design you describe makes a lot of sense. Ideally we should support the most common use case out-of-the-box with little/no required config, but also make it possible to serve more advanced use cases like yours.

Regarding the name, this is somewhat unconventional but what do you think about ApolloBaseService instead of BaseApolloService? I like it because it keeps the Apollo prefix.

@viniciussbs
Copy link
Contributor

If this base service is a mixin, you should take a look at #139.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants