Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve tests #98

Open
villander opened this issue Feb 18, 2018 · 3 comments
Open

Improve tests #98

villander opened this issue Feb 18, 2018 · 3 comments

Comments

@villander
Copy link
Contributor

We have almost 80% coverage, which is very good. But the place we least test is where you most need, in apollo service, the heart of the addon. We need help with this.

image

@bgentry
Copy link
Member

bgentry commented Feb 18, 2018

@villander any interest in a PR to get code coverage included as part of our CodeClimate runs?

https://codeclimate.com/github/bgentry/ember-apollo-client

@josemarluedke
Copy link
Member

@villander I'm curious about the status of this now. Any change you can rerun the coverage report?

@josemarluedke
Copy link
Member

While a good unit test coverage is good, I think we need to improve our tests by adding more application/rendering tests. We need to make sure we interact well with ember, we should create more tests cases to mimic how users use this project. Today we mock a lot of methods to do testing, we should minimize that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants