Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: Missions with only illegal passengers and not cargo are not illegal #10084

Open
1 task done
ziproot opened this issue May 19, 2024 · 3 comments · May be fixed by #10092
Open
1 task done

Bug: Missions with only illegal passengers and not cargo are not illegal #10084

ziproot opened this issue May 19, 2024 · 3 comments · May be fixed by #10092
Labels
bug Something in the game is not behaving as intended mechanics Things dealing with the mechanics & code of how the game works

Comments

@ziproot
Copy link
Contributor

ziproot commented May 19, 2024

Is there an existing issue for this?

  • I have searched the existing issues

Describe the bug

If you take a mission with illegal passengers and not illegal cargo (e.g. the slave transport jobs or the shady passenger jobs), you cannot actually be fined or sentenced to death.

Steps to Reproduce

  1. Load the save
  2. Depart
  3. Wait for Hai authorities to scan you
  4. See how you are not fined
  5. Land on Everhope (security 1)
  6. See how you are not fined

Expected Behavior

If you are successfully scanned or caught by planetary security, you should be fined and the mission should fail.

Screenshots

image

Link to save file

Remnant Test~Shady Passenger.txt

Operating System

Debian 12 Bookworm

Game Source

GitHub Releases

Game Version

v0.10.6

Additional Information

No response
@ziproot ziproot added bug Something in the game is not behaving as intended unconfirmed More information is needed to be sure this report is true labels May 19, 2024
@OcelotWalrus
Copy link
Contributor

Turns out only one of the Sady Passenger Transport missions was missing the illegal tag.

@OcelotWalrus OcelotWalrus mentioned this issue May 22, 2024
Closed
@ziproot
Copy link
Contributor Author

ziproot commented May 22, 2024

The mission in the attached save has the illegal tag.

@OcelotWalrus
Copy link
Contributor

Well this's really weird.

@TomGoodIdea TomGoodIdea added mechanics Things dealing with the mechanics & code of how the game works and removed unconfirmed More information is needed to be sure this report is true labels May 22, 2024
@TomGoodIdea TomGoodIdea linked a pull request May 22, 2024 that will close this issue
Open
@ziproot ziproot changed the title Missions with only illegal passengers and not cargo are not illegal Bug: Missions with only illegal passengers and not cargo are not illegal Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something in the game is not behaving as intended mechanics Things dealing with the mechanics & code of how the game works
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(mechanics): Apply fines for illegal mission passengers TomGoodIdea/endless-sky
3 participants
@OcelotWalrus @TomGoodIdea @ziproot