-
Notifications
You must be signed in to change notification settings - Fork 994
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some escorts get stuck after going through a wormhole. #5541
Comments
A variant:
|
Another variant:
|
This just happened to me on 0.9.16 (steam) even though this is supposed to be fixed. |
Oh no. Can you provide a save file? Thanks! |
In this save the escorts are already stuck in Ultima Thule, while the flagship is in Heia Due. If you go back and refuel escorts, they follow through the wormhole without problem. |
Downloaded the save file. I selected one of the escorts in Ultima Thule (clicked on icon in lower left screen), opened the map, selected Waypoint, right-clicked on the mini-map to tell the escort to go to Waypoint...and it went to Waypoint. Repeated with the second escort, and then used G to gather them to me (once they accumulated enough fuel to make the hyperjump). No need to go back to Ultima Thule to "get" them. |
This is not the point. The point is, they do not follow the flagship automatically as one would expect. |
Pinning this issue since it's haunting us. |
As an aside, that testing code that displays a ships fuel and stuff looks really useful for debugging. |
But I got escorts stuck while i was already playing on the 0.9.16 version (which is supposed to include that fix?) |
Ok, that definitely isn't supposed to happen. |
In @eternal-sorrow 's save, one reason the escorts are semi-permanently stuck is because they are out of fuel and too far from the system center for solar collection to do very much. Incidentally that second branch is never reachable because it needs The reason why the escorts aren't taking the wormhole even when they're out of fuel is similarly because all branches that can make the escorts take the wormhole are either behind a I have the impression (but I'm very new to all this code) that the I can't judge yet if that has unexpected side effects though, which is why I'm not yet submitting this as a PR. |
This is a small fix-up of endless-sky#7379 fixing a new report in endless-sky#5541. MoveEscort() has two branches that were blocked if an escort was out of fuel. These two branches were responsible for planning how an escort should follow its parent, and already contain code handling the out-of-fuel condition, by either landing to refuel (via SelectRoute) or by moving to the system center as a fallback. Also flying through a wormhole without fuel was blocked as an option as a side effect. This patch enables taking those branches for escorts without fuel.
Describe the bug
Some escorts get stuck after going through a wormhole in the opposite direction of the flagship at the same time.
The escorts is set a directly unreachable system as the target system and its JumpsRemaining() returns 0 forever. I think the escorts got in the wormhole at the same time when the flagship exited from the wormhole.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
All escorts follow the flagship.
Screenshots
Note: I created it from a modified code for debugging.
The label "Target System:" of a ship shows the return value of ship.GetTargetSystem().
"Fuel:" shows the return value of ship.Fuel().
"Jump Remaining:" shows the return value of ship.JumpsRemaining().
The first word of "Route:" is the current system when AI::MoveEscort() calls ship.SetTargetSystem(dest), the second word is its dest.
The current system is not equal to the first word of "Route:" of the escorts. It means ship.SetTargetSystem(dest) was called when the ship was in the different system, and then the target system of the ship was not cleared after going through a wormhole.
System (please complete the following information):
Link to save file
NA
Additional context
This behavior is similar to #5011, #4582, and #3608, and also possibly #4362, but this issue is caused after going through a wormhole.
The text was updated successfully, but these errors were encountered: