Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node API prevent concurrent writes #12

Closed
rymsha opened this issue Feb 21, 2024 · 1 comment
Closed

Node API prevent concurrent writes #12

rymsha opened this issue Feb 21, 2024 · 1 comment
Assignees

Comments

@rymsha
Copy link
Contributor

rymsha commented Feb 21, 2024

Check how same node (equal id) behaves
Hopefully it is OK, but if not - we need to synchronize requests a bit more

A smaller but related problem - Node API writes is eventually consistent in cluster - check if it matters.

@rymsha rymsha self-assigned this Feb 23, 2024
@rymsha rymsha added this to the 1.0.0 milestone Feb 27, 2024
@rymsha
Copy link
Contributor Author

rymsha commented Mar 8, 2024

There are two races harmful races
In Blob store.

When file with the same name is written FileAlreadyExistsException can be thrown. It should be fixed in XP as it may happen for unrelated nodes with different ids - enonic/xp#10447

In search indexing.
enonic/xp#10448
But we write equally good node and don't care about timestamp or versionId. So it is not hurting us

@rymsha rymsha removed this from the 1.0.0 milestone Mar 8, 2024
@rymsha rymsha closed this as not planned Won't fix, can't repro, duplicate, stale Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant