Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OptionSet performance: do not create option inputs until option is selected #5097

Closed
ashklianko opened this issue Sep 7, 2022 · 1 comment
Closed

OptionSet performance: do not create option inputs until option is selected #5097

ashklianko opened this issue Sep 7, 2022 · 1 comment
Labels
Tech Debt Code improvements

Comments

@ashklianko
Copy link
Member

ashklianko commented Sep 7, 2022 •
edited

Having an option set makes all inputs, including unselected ones (especially with <expanded>false</expanded> ), be created immediately when opening wizard. That may potentially lead to performance issues, thus need to instantiate items only when option is selected and items become visible.
This issue will have impact on content's property tree layout and comparing it with saved property tree.
@ashklianko ashklianko added the Tech Debt Code improvements label Sep 7, 2022
@alansemenov alansemenov mentioned this issue Sep 27, 2022
Open
@alansemenov
Copy link
Member

Issue moved to enonic/lib-admin-ui #2780 via Zenhub

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Tech Debt Code improvements
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ashklianko @alansemenov