Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FormInputEl old value is assigned to wrong string #2984

Open
edloidas opened this issue Jan 23, 2023 · 0 comments
Open

FormInputEl old value is assigned to wrong string #2984

edloidas opened this issue Jan 23, 2023 · 0 comments
Labels
Bug Something isn't working

Comments

@edloidas
Copy link
Member

When the oldValue is set, the string concatenation is used, that will automatically convert the right side value to string. It is probably not what was intended, as null will be converted to 'null' and undefined to 'undefined'.

this.oldValue = '' + value;

This convertion may lead to strange side effects, when the input was reset or is not yet dirty.

@edloidas edloidas added the Bug Something isn't working label Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant