Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apptools, futures, numpy, scimath are core dependencies #26

Open
rahulporuri opened this issue Feb 1, 2019 · 1 comment
Open

apptools, futures, numpy, scimath are core dependencies #26

rahulporuri opened this issue Feb 1, 2019 · 1 comment

Comments

@rahulporuri
Copy link
Contributor

rahulporuri commented Feb 1, 2019

apptools is a core dependency on codetools but is not listed as one in the package __requires__. See

from apptools import sweet_pickle

from scimath.units.api import UnitArray

from concurrent.futures import Executor, Future
from concurrent.futures import ThreadPoolExecutor

__requires__ = [
'six',
'traits',
]

@rahulporuri rahulporuri changed the title apptools is a core dependency apptools, scimath are core dependencies Feb 1, 2019
@rahulporuri rahulporuri changed the title apptools, scimath are core dependencies apptools, futures, scimath are core dependencies Feb 1, 2019
@rahulporuri rahulporuri changed the title apptools, futures, scimath are core dependencies apptools, futures, numpy, scimath are core dependencies Feb 18, 2019
@itziakos
Copy link
Member

itziakos commented Feb 18, 2019

I think that codetools is of a group of almost independent sub-packages so I would not think that dependencies in the context submodule are part of the core dependencies that should be part of the setup.py. I think that the dependencies of each sub-package should be captures in a extras

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants