Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wagtail 3.0 compatibility? #2

Closed
djch opened this issue Jul 6, 2022 · 3 comments
Closed

Wagtail 3.0 compatibility? #2

djch opened this issue Jul 6, 2022 · 3 comments

Comments

@djch
Copy link

djch commented Jul 6, 2022

It seems that I get a failure of dependency resolution trying to update to Wagtail 3.0 with wagtail_srcset in my Pipfile. For all I know this project is still compatible, but perhaps there's a dependency locking it to Wagtail 2.x somewhere in this project?

@ephes
Copy link
Owner

ephes commented Nov 1, 2022

Ups, didn't notice this issue. You are right, in the pyproject.toml there's an implicit upper limit to Wagtail 2: wagtail = "^2.8". Here's a video describing the problem in detail.

Maybe I find time this week to switch from poetry to flit for building the package and remove the upper version limits.

@djch
Copy link
Author

djch commented Nov 1, 2022

Thanks!

Not really related to this issue, but apparently Wagtail are working on some kind of first-party support for srcset images as well: wagtail/rfcs#71

@ephes
Copy link
Owner

ephes commented Nov 1, 2022

Yes, I saw this too and this would be really great if there's a proper solution for this. But it seems a little bit strange to me that the rfc is mainly talking about traffic reduction. The only reason I built wagtail_srcset was because my fotos looked awful on a standard Wagtail installation.

Reducing traffic is an also important, but completely different problem. The easiest way to accomplish that would be to look into using different quality settings for different images using something like cjpeg-dssim (there's a lot more to this problem, of course - especially if you take into account different compression formats like webp etc.. but for jpeg it's already complicated enough). But maybe there's also some lack of understanding on my site..

ephes added a commit that referenced this issue Nov 3, 2022
ephes added a commit that referenced this issue Nov 3, 2022
ephes added a commit that referenced this issue Nov 3, 2022
ephes added a commit that referenced this issue Nov 3, 2022
ephes added a commit that referenced this issue Nov 3, 2022
ephes added a commit that referenced this issue Nov 3, 2022
ephes added a commit that referenced this issue Nov 3, 2022
ephes added a commit that referenced this issue Nov 3, 2022
ephes added a commit that referenced this issue Nov 3, 2022
ephes added a commit that referenced this issue Nov 3, 2022
ephes added a commit that referenced this issue Nov 3, 2022
ephes added a commit that referenced this issue Nov 3, 2022
ephes added a commit that referenced this issue Nov 3, 2022
ephes added a commit that referenced this issue Nov 3, 2022
ephes added a commit that referenced this issue Nov 3, 2022
ephes added a commit that referenced this issue Nov 3, 2022
ephes added a commit that referenced this issue Nov 3, 2022
ephes added a commit that referenced this issue Nov 3, 2022
ephes added a commit that referenced this issue Nov 3, 2022
ephes added a commit that referenced this issue Nov 3, 2022
ephes added a commit that referenced this issue Nov 3, 2022
ephes added a commit that referenced this issue Nov 3, 2022
ephes added a commit that referenced this issue Nov 3, 2022
ephes added a commit that referenced this issue Nov 3, 2022
ephes added a commit that referenced this issue Nov 3, 2022
ephes added a commit that referenced this issue Nov 3, 2022
@ephes ephes closed this as completed Nov 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants