Escript creation failure reason swallowed by post-hook failure.

[richcarl]

rebar3/apps/rebar/src/rebar_prv_escriptize.erl

Line 99 in a16f41a

throw:Err=?PRV_ERROR(_) -> Err

This catch was introduced in #2532 but there is still a problem: if the escript creation fails and the exception is caught, the call to rebar_hooks:run_all_hooks() below will be executed and will likely fail in itself since there will be no _build/prod/bin/rebar3 to copy. This will cause the first exception to be forgotten, and you simply get _build/prod/bin/rebar3: No such file or directory and Hook for escriptize failed! without a clue as to why. (The actual error was {bad_app, App} just as added in #2532.)

Not sure what solution you would prefer, but skipping the post-hooks if creation fails seems reasonable to me.

[ferd]

I think this may be a duplicate of #2798