-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement compaction support in robustness test #17833
Conversation
Skipping CI for Draft Pull Request. |
f87ed59
to
7ae772b
Compare
713985e
to
46e255e
Compare
Need to fix one more case, allow gofailpoints triggered by compaction to allow to be triggered by traffic. |
46e255e
to
7f3c5fc
Compare
7f3c5fc
to
b055c02
Compare
/retest |
b055c02
to
6907947
Compare
Yey, revision returned by compaction is not linearizable. https://github.com/etcd-io/etcd/actions/runs/9179653925?pr=17833 |
6907947
to
7f65b69
Compare
I don't understand why the line is drawn at the end of the compact op in the TestRobustnessExploratory_Etcd_HighTraffic_ClusterOfSize3 report. |
Assuming that compaction returns linearizable revision (that might not be necessarily a property we want to provide), operations As mentioned above, it's not necessarily a bug, but at least a undocumented behavior. It stems from fact that etcd puts revision in the same field of response, independent of its meaning. Depending on the request the revision can be interpreted in a different way. Some examples:
|
b1032f6
to
e87f65b
Compare
2974288
to
1512732
Compare
/retest |
1 similar comment
/retest |
/retest |
0079120
to
f417c44
Compare
b73a516
to
4ac50b1
Compare
Ready for review, finally. |
func (t triggerCompact) Available(e2e.EtcdProcessClusterConfig, e2e.EtcdProcess) bool { | ||
func (t triggerCompact) Available(config e2e.EtcdProcessClusterConfig, _ e2e.EtcdProcess) bool { | ||
// Since introduction of compaction into traffic, injecting compaction failpoints started interfeering with peer proxy. | ||
// TODO: Re-enable the peer proxy for compact failpoints when we confirm the root cause. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there an issue tracking this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ping @fuweid @MadhavJivrajani |
Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
4ac50b1
to
5959110
Compare
/retest |
No description provided.