Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch from grpc-ecosystem/go-grpc-prometheus to grpc-ecosystem/go-grpc-middleware/providers/prometheus #17974

Conversation

dims
Copy link
Contributor

@dims dims commented May 9, 2024

Related to: kubernetes/kubernetes#124695

go-grpc-prometheus has been archived since Apr 18, 2023 and the alternative seems to be:
https://github.com/grpc-ecosystem/go-grpc-middleware/tree/main/providers/prometheus

@k8s-ci-robot
Copy link

Hi @dims. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@dims dims force-pushed the switch-from-grpc-ecosystem/go-grpc-prometheus-to-grpc-ecosystem/go-grpc-middleware/providers/prometheus branch 3 times, most recently from 085c3b1 to 9248398 Compare May 9, 2024 18:32
Signed-off-by: Davanum Srinivas <davanum@gmail.com>
@dims dims force-pushed the switch-from-grpc-ecosystem/go-grpc-prometheus-to-grpc-ecosystem/go-grpc-middleware/providers/prometheus branch from 9248398 to 816f48e Compare May 9, 2024 19:58
@ahrtr
Copy link
Member

ahrtr commented May 10, 2024

…pc-middleware/providers/prometheus

Signed-off-by: Davanum Srinivas <davanum@gmail.com>
@dims dims force-pushed the switch-from-grpc-ecosystem/go-grpc-prometheus-to-grpc-ecosystem/go-grpc-middleware/providers/prometheus branch from 816f48e to b4216c3 Compare May 10, 2024 14:05
@ahrtr
Copy link
Member

ahrtr commented May 11, 2024

@dims The golang version has already bumped in another PR, please rebase this PR. thx

@dims dims closed this Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants