-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DO-NOT-MERGE] Rollback changes on #17719 #18018
Conversation
Hi @henrybear327. Thanks for your PR. I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
c846c0e
to
8c469d1
Compare
137ecf5
to
c1cc765
Compare
Reference: - etcd-io#17719 - etcd-io/gofail#64 Signed-off-by: Chun-Hung Tseng <henrybear327@gmail.com>
c1cc765
to
c635317
Compare
Using the latest commit in github.com/henrybear327/gofail to verify the gofail is working as intended, thus, do not merge. |
/retest |
@henrybear327: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Seq 1 (I can't use /retest so I have to force changes on commits...) Signed-off-by: Chun-Hung Tseng <henrybear327@gmail.com>
c635317
to
2f73196
Compare
Close this PR because the demo purpose is completed. |
Reference:
Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.