Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DO-NOT-MERGE] Rollback changes on #17719 #18018

Closed
wants to merge 2 commits into from

Conversation

@k8s-ci-robot
Copy link

Hi @henrybear327. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Reference:
- etcd-io#17719
- etcd-io/gofail#64

Signed-off-by: Chun-Hung Tseng <henrybear327@gmail.com>
@henrybear327
Copy link
Contributor Author

henrybear327 commented May 15, 2024

Using the latest commit in github.com/henrybear327/gofail to verify the gofail is working as intended, thus, do not merge.

@henrybear327
Copy link
Contributor Author

/retest

@k8s-ci-robot
Copy link

@henrybear327: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Seq 1 (I can't use /retest so I have to force changes on commits...)

Signed-off-by: Chun-Hung Tseng <henrybear327@gmail.com>
@henrybear327 henrybear327 changed the title Rollback changes on #17719 [Test] Rollback changes on #17719 May 15, 2024
@henrybear327 henrybear327 changed the title [Test] Rollback changes on #17719 [DO-NOT-MERGE] Rollback changes on #17719 May 15, 2024
@henrybear327
Copy link
Contributor Author

Close this PR because the demo purpose is completed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants