Errors in TODTransfer Pattern

[ritzdorf]

Reference:

securify/src/test/java/ch/securify/patterns/TODTransferTest.java

Line 36 in 604fb57

// TODO: fix

Additional examples:

pragma solidity 0.4.24;

contract game {
  bool won = false;
  
  function play() public {
    if (!won) {
      won = true;
      msg.sender.transfer(1);
    }
  }

  function play2() public {
    require(!won);
    won = true;
    msg.sender.transfer(1);
  }
}

play and play2 have different analysis results with regards to TODTransfer.

pragma solidity 0.4.24;

contract game {
  bool won = false;

  function play() public {
    if (!won) {
      won = true;
      msg.sender.transfer(10 ** 18);
    } else {
      msg.sender.transfer(10 ** 18);
    }
    msg.sender.transfer(10 ** 18);
  }
}

The last transfer is also tagged as TODTransfer. It is unclear whether that is desirable or not.