Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rate limit for faucet #29783

Closed
emailtovamos opened this issue May 15, 2024 · 2 comments
Closed

Rate limit for faucet #29783

emailtovamos opened this issue May 15, 2024 · 2 comments

Comments

@emailtovamos
Copy link

Rationale

Currently I see no provision to rate limit in case of DOS attack on faucet. Please correct me if I am wrong.

Implementation

There should be rate limiting mechanism in place to ensure the faucet resources don't get maxed up in an ip decides to send lots of requests per second.

@karalabe
Copy link
Member

We dropped out faucet code many years ago, so unsure which faucet you're referring to.

@weiihann
Copy link
Contributor

For those who are looking to implement a faucet, this repo might be helpful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants