Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make methods() ignore subroutines declared as functions #222

Closed
schwern opened this issue Jun 4, 2012 · 4 comments
Closed

Make methods() ignore subroutines declared as functions #222

schwern opened this issue Jun 4, 2012 · 4 comments

Comments

@schwern
Copy link
Contributor

schwern commented Jun 4, 2012

Change the methods meta method to ignore any subroutine declared as a function. Use the methods provided by perl5i::Signature to check.

my $sig = $code->signature;
next if $sig and $sig->is_method;
carloslima added a commit to carloslima/perl5i that referenced this issue Apr 13, 2013
@carloslima
Copy link
Contributor

I'm not sure whether I was supposed to do use perl5i::2::autobox at lib/perl5i/2/Meta.pm or not.

Let me know if there is any change you'd like me to make and I'll fix it :-)

@carloslima
Copy link
Contributor

Did I approach it the wrong way or is there no longer interest in this issue?
I'd be happy to address any problem, provided I get some feedback :)

@schwern
Copy link
Contributor Author

schwern commented May 27, 2013

No no, we're just being slow.

schwern added a commit that referenced this issue Jul 23, 2014
Make methods() ignore subroutines declared as functions for #222
@schwern
Copy link
Contributor Author

schwern commented Jul 23, 2014

Done by #253

@schwern schwern closed this as completed Jul 23, 2014
@schwern schwern mentioned this issue Jul 23, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants