Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin "Barista for Event Espresso" hides some of the themes in WordPress admin #1258

Closed
alexkuc opened this issue Aug 25, 2023 · 5 comments · Fixed by #1300
Closed

Plugin "Barista for Event Espresso" hides some of the themes in WordPress admin #1258

alexkuc opened this issue Aug 25, 2023 · 5 comments · Fixed by #1300
Assignees
Labels
C: UI/UX 🚽 category D: WP admin 🏠 domain: WordPress Dashboard P4: low priority 😎 priority: low S6: has fix 💉 status (for use on issues) T: bug 🐛 type: FIX - any bug fixes

Comments

@alexkuc
Copy link
Contributor

alexkuc commented Aug 25, 2023

When plugin "Barista for Event Espresso" is active and when navigating to WordPress -> Admin -> Appearance -> Themes, not all the themes are shown.

To quickly reproduce this issue:

  • activate core plugin
  • activate barista plugin
  • comment out these lines:

barista/lib/Barista.php

Lines 275 to 281 in 7371982

$this->overrideStyle(
$styles,
$handle,
$this->url($css_relative_path),
$dependencies,
$version
);

It appears that when styles are being overridden, some of the theme styles are being overridden. Perhaps, this is unintentional behaviour. Perhaps it serves that actual useful function and UI bug is purely a side effect.

Since there was some discussion about updating barista tooling once E2E is functional, I'll leave this issue open but mark it as low priority. Perhaps in the process of upgrading/replacing webpack, the Barista.php will have to be updated/replaced.

@alexkuc alexkuc added T: bug 🐛 type: FIX - any bug fixes C: UI/UX 🚽 category D: WP admin 🏠 domain: WordPress Dashboard P4: low priority 😎 priority: low S1: new 👶🏻 status labels Aug 25, 2023
@alexkuc alexkuc self-assigned this Aug 25, 2023
@alexkuc
Copy link
Contributor Author

alexkuc commented Aug 25, 2023

After using wp-cli to activate the hidden theme to further investigate the issue, I can no longer reproduce the issue.

@alexkuc alexkuc closed this as completed Aug 25, 2023
@alexkuc
Copy link
Contributor Author

alexkuc commented Aug 25, 2023

I have unintentionally left the commented out lines. Re-opening the issue.

@alexkuc alexkuc reopened this Aug 25, 2023
@alexkuc
Copy link
Contributor Author

alexkuc commented Aug 25, 2023

Current workaround for this issue is:

  • deactivate barista plugin, activate relevant theme, re-activate barista plugin
  • use wp-cli: wp theme activate <theme>

@tn3rb
Copy link
Member

tn3rb commented Apr 29, 2024

weird...

ALL of the assets being passed to overrideStyle() have a handle that starts with eventespresso-

totally baffled as to how this could be affecting themes

@alexkuc
Copy link
Contributor Author

alexkuc commented Apr 30, 2024

My guess is that style.css (the theme's main stylesheet) gets somehow overriden

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: UI/UX 🚽 category D: WP admin 🏠 domain: WordPress Dashboard P4: low priority 😎 priority: low S6: has fix 💉 status (for use on issues) T: bug 🐛 type: FIX - any bug fixes
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants