Update type AssignmentStatus in Ticket Assignment Manager

[alexkuc]

For type AssignmentStatus, need to replace status of null (currently implied due to how TypeScript strictness is configured) with NO_RELATION or similar as it is currently done in the Ticket Assignment Manager (TAM) legend:

barista/domains/core/admin/eventEditor/src/ui/ticketAssignmentsManager/types.ts

Line 17 in 46c1949

export type AssignmentStatus = 'OLD' | 'NEW' | 'REMOVED';

Currently, type maps as follows to the legend:

Type	Legend
OLD	existing relationship
NEW	add new relationship
REMOVED	remove existing relationship
n\a	invalid relationship
n\a	no relationship

The code that generates the actual status as follows:

barista/domains/core/admin/eventEditor/src/ui/ticketAssignmentsManager/data/useDataStateManager.ts

Lines 71 to 91 in 46c1949

	const getAssignmentStatus = useCallback(
	({ datetimeId, ticketId }): AssignmentStatus => {
	const oldRelatedTickets = getOldRelation({ datetimeId });
	const newRelatedTickets = assignmentManager.getAssignedTickets({ datetimeId });
	const isInOld = oldRelatedTickets.includes(ticketId);
	const isInNew = newRelatedTickets.includes(ticketId);
	switch (true) {
	case isInOld && isInNew:
	return 'OLD';
	case !isInOld && isInNew:
	return 'NEW';
	case isInOld && !isInNew:
	return 'REMOVED';
	case !isInOld && !isInNew:
	return null;
	}
	},
	[assignmentManager, getOldRelation]
	);

Curiously enough, there is no provisioning for the so-called "invalid relationship" status.

[tn3rb]

there is no provisioning for the so-called "invalid relationship" status.

if we add one... then wouldn't that make it a "valid" status 🤔

[alexkuc]

Well… that's the curious thing about it. The legend has the status but the codebase does not. So, either legend was created before the code responsible for generating the status or the status "invalid" existed but was the removed from the database whereas legend was not updated.

[tn3rb]

would be easier then to fix the legend, but having an explicit type for no relation (maybe NONE) would be good.