Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Duplicate DOM Utility #1292

Open
tn3rb opened this issue Apr 2, 2024 · 0 comments
Open

Remove Duplicate DOM Utility #1292

tn3rb opened this issue Apr 2, 2024 · 0 comments

Comments

@tn3rb
Copy link
Member

tn3rb commented Apr 2, 2024

Declarations for getHTMLElementClientRect() are found in the following locations:

  • packages/hooks/src/utils/getHTMLElementClientRect.ts
  • packages/utils/src/dom/getHTMLElementClientRect.ts

It appears that only the first declaration is used by packages/hooks/src/useRect.ts, so it makes sense to keep that version and delete the second... HOWEVER... the function itself seems to fit better logically into the second location considering it is a utility pertaining to the DOM 🤷🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant