Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ticket caps set with legacy editor not showing in EDTR #38

Open
Pebblo opened this issue Jul 7, 2021 · 5 comments
Open

Fix ticket caps set with legacy editor not showing in EDTR #38

Pebblo opened this issue Jul 7, 2021 · 5 comments

Comments

@Pebblo
Copy link
Member

Pebblo commented Jul 7, 2021

EDIT - I'd started this issue so published it, however, it looks like EDTR isn't reading/writing any capabilities on tickets be that new or legacy tickets.

See #39
Moved to #980


If you set a capability on a ticket using the legacy editor, then switch over to EDTR, the cap set on the doesn't doesn't show in EDTR.

Steps to reproduce

Use EE4 core dev branch.
Use WP User add-on dev branch.

Set EE to use the Legacy editor (Events -> Default Settings -> Activate Advanced Editor?)
I leave that section open in a tab for easy switching.

Create a new event and setup at least one ticket which requires a capability.

I use 3 tickets, 'none', 'read', 'something' (the name of the ticket matches the cap set on the ticket).

So something like this: https://monosnap.com/file/iXm98cL8YdTbiNPyh6sd8LORPxL6sp

In the tab with the advanced editor option setting, set EE to load the Advanced Editor.

Either refresh the event editor tab or open up the event again in a new tab (again I keep both to compare easily)

Edit one of the tickets, my example if the 'something' ticket, check the WP users section:
https://monosnap.com/file/EJqTkFx36izBg4XxdXztxpShtXNOZ3

No ticket cap is set.

@Pebblo Pebblo self-assigned this Jul 7, 2021
@tn3rb
Copy link
Member

tn3rb commented Mar 24, 2022

This appears to be fixed now.

I followed the steps you outlined above:

  • created new event using legacy editor
  • added caps to tickets: read && something
  • saved event and switched to EDTR

here's the two tickets' caps:

Screenshot 2022-03-24 161559

Screenshot 2022-03-24 161617

can you plz test again and confirm?

@Pebblo
Copy link
Member Author

Pebblo commented Mar 25, 2022

Currently, dev is broken relating to issues in master, see: eventespresso/event-espresso-core#3773

So limited testing on this as I want to test that multiple tickets still work. The single ticket set with a capability seems to work fine, but I'd like to test this once dev is working proper again.

@Saam01 has tested this using multiple tickets created in legacy editor before he pulled the latest master, it appears to be working as expected.

Will retest once #3773 is merged.

@garthkoyle
Copy link

#3773 is merged and I confirmed this morning that a new ticket is created. This is ready again for testing.

@garthkoyle garthkoyle assigned ghost May 17, 2022
@ghost
Copy link

ghost commented May 26, 2022

@garthkoyle Tested it on my end and it seems to be working as expected.

@garthkoyle
Copy link

@Pebblo what's the next step for this?

@tn3rb tn3rb unassigned ghost Oct 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants