Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gcc 9 compilation is broken #86

Open
witaly-iwanow opened this issue Jun 6, 2020 · 2 comments
Open

gcc 9 compilation is broken #86

witaly-iwanow opened this issue Jun 6, 2020 · 2 comments

Comments

@witaly-iwanow
Copy link

I'm getting these errors on gcc 9.3.0 (Ubuntu 20.04). A bit of googling revealed that it's usually resolved with adding an = operator declared as = default. I can't figure it out though, gotta love templates - errors are as confusing as ever, not much has changed in the last 15 years since I started dabbling in C++. TIA
salsify-build-error-log.txt

@witaly-iwanow
Copy link
Author

Looks like replacing shady const Context & operator=( const Context & ) { return *this; } with const Context & operator=( const Context & ) = delete; does the trick

@witaly-iwanow
Copy link
Author

I have it fixed in my fork (https://github.com/witaly-iwanow/alfalfa), along with one more Ubuntu 20.04 fix. Let me know if you're interested in merging those (the second fix can probably break things for older libx264-dev builds)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant