Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Markdown outputs are not rendering in ipywidgets #741

Open
stevejpurves opened this issue Mar 15, 2024 · 1 comment
Open

Markdown outputs are not rendering in ipywidgets #741

stevejpurves opened this issue Mar 15, 2024 · 1 comment
Labels

Comments

@stevejpurves
Copy link
Member

Describe the bug

context
When I do use any of the examples that have markdown cell output
https://executablebooks.github.io/thebe/ipywidgets.html

expectation
I expected markdown to be rendered

bug
But instead I get plain text happens

problem
This is a problem for people!

Reproduce the bug

run this and look at the output of the cookies example https://executablebooks.github.io/thebe/ipywidgets.html

List your environment

No response

@stevejpurves
Copy link
Member Author

The issue stems from changes to the IRendermimeRegistry interface in juptyerlab.

Now this requires a separate markdown renderer, even to render markdown mimetype outputs and seems to be now inextricably linked with codemirror editor languages, even though it's a concern of output rendering for mimebundles.

We'll need to supply a markdown renderer of some form to the rendermime registry, using the marked renderer as-per jupyterlab will mean pulling in @juptyerlab/codemirror or building out a stub implementation of IEditorLanguageRegistry :( . Probably it's better to consider a different/better parser and use that? maybe with the need to wrap it, potentially we can jsut use mystjs here cc @rowanc1?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant