[SDK51][Dev Client] Development client on android fails to open eas update from updates list with "Failed to open app"

[romanonthego]

Summary

Development client on android fails to open an update from the updates list with "Failed to open app" message:

---

Update itself also seems fine as you could open it just fine from direct url:

iOS seems fine, no issues encountered as well no issues had been seen with SKD49 and SDK50;

Managed or bare workflow?

bare

What platform(s) does this occur on?

Android

Package versions

"expo-dev-client": "~4.0.13",
"expo-updates": "~0.25.11",
"expo": "~51.0.4",
"react-native": "0.74.1",

Environment

expo-env-info 1.2.0 environment info:
    System:
      OS: macOS 14.4.1
      Shell: 5.9 - /bin/zsh
    Binaries:
      Node: 21.7.3 - /opt/homebrew/bin/node
      Yarn: 1.22.21 - /opt/homebrew/bin/yarn
      npm: 10.5.0 - /opt/homebrew/bin/npm
      Watchman: 2024.04.15.00 - /opt/homebrew/bin/watchman
    Managers:
      CocoaPods: 1.15.2 - /opt/homebrew/lib/ruby/gems/3.0.0/bin/pod
    SDKs:
      iOS SDK:
        Platforms: DriverKit 23.4, iOS 17.4, macOS 14.4, tvOS 17.4, visionOS 1.1, watchOS 10.4
    IDEs:
      Android Studio: 2021.1 AI-211.7628.21.2111.8139111
      Xcode: 15.3/15E204a - /usr/bin/xcodebuild
    npmGlobalPackages:
      eas-cli: 9.0.5
      expo-cli: 6.3.10
    Expo Workflow: bare

Reproducible demo

https://github.com/romanonthego/empty-app

Stacktrace (if a crash is involved)

No response

[romanonthego]

More information: it appears that expo server is responding with 406 status code for https://u.expo.dev/update/:uuid

this is the request from the android network inspector:

curl 'https://u.expo.dev/update/:update_id:' \
  -H 'accept: application/expo+json,application/json' \
  -H 'accept-encoding: gzip' \
  -H 'connection: Keep-Alive' \
  -H 'expo-dev-client-id: :client_id:' \
  -H 'expo-platform: android' \
  -H 'host: u.expo.dev' \
  -H 'user-agent: okhttp/4.11.0' \
  --compressed

> EAS Update clients must accept "multipart/mixed" responses

adding multipart/mixed fixes the issue with the request:

curl 'https://u.expo.dev/update/:update_id:' \
  -H 'accept: application/expo+json,application/json,multipart/mixed' \
  -H 'accept-encoding: gzip' \
  -H 'connection: Keep-Alive' \
  -H 'expo-dev-client-id: :client_id:' \
  -H 'expo-platform: android' \
  -H 'host: u.expo.dev' \
  -H 'user-agent: okhttp/4.11.0' \
  --compressed

> -------ExpoManifestBoundary-LQ4Qq5LDR7qrETeHacn_3A
> Content-Disposition: form-data; name="manifest"
> Content-Type: application/json
> .....

[brentvatne]

hi there! can you share a link to the full update url to secure@expo.dev? thanks

[romanonthego]

btw, I have tried to apply patch to the expo-dev-launcher

diff --git a/node_modules/expo-dev-launcher/android/src/main/java/expo/modules/devlauncher/launcher/manifest/DevLauncherManifestParser.kt b/node_modules/expo-dev-launcher/android/src/main/java/expo/modules/devlauncher/launcher/manifest/DevLauncherManifestParser.kt
index 714891a..7b0835d 100644
--- a/node_modules/expo-dev-launcher/android/src/main/java/expo/modules/devlauncher/launcher/manifest/DevLauncherManifestParser.kt
+++ b/node_modules/expo-dev-launcher/android/src/main/java/expo/modules/devlauncher/launcher/manifest/DevLauncherManifestParser.kt
@@ -42,7 +42,7 @@ class DevLauncherManifestParser(
   private fun getHeaders(): Headers {
     val headersMap = mutableMapOf(
       "expo-platform" to "android",
-      "accept" to "application/expo+json,application/json"
+      "accept" to "application/expo+json,application/json,multipart/mixed"
     )
     if (installationID != null) {
       headersMap["expo-dev-client-id"] = installationID

which in turn lead to another error:

My current theory is that during upgrade to SDK51 we somehow have not properly updated some internal dependencies of expo-dev-launcher? Any tips would help at this point :)

[romanonthego]

hi there! can you share a link to the full update url to secure@expo.dev? thanks

will do

[romanonthego]

@brentvatne sorry to bother you, but did you by any chance have time to check update?

[romanonthego]

for comparison:
this is request going to the server with SDK49:

curl 'https://u.expo.dev/update/:uuid:' \
  -H 'accept: multipart/mixed,application/expo+json,application/json' \
  -H 'accept-encoding: br,gzip' \
  -H 'connection: Keep-Alive' \
  -H 'eas-client-id: :uuid:' \
  -H 'expo-accept-signature: false' \
  -H 'expo-api-version: 1' \
  -H 'expo-dev-client-id: :uuid:' \
  -H 'expo-json-error: true' \
  -H 'expo-platform: android' \
  -H 'expo-protocol-version: 1' \
  -H 'expo-release-channel: default' \
  -H 'expo-runtime-version: 7.3.1' \
  -H 'expo-updates-environment: DEVELOPMENT' \
  -H 'host: u.expo.dev' \
  -H 'user-agent: okhttp/4.11.0' \
  --compressed

this is after update:

curl 'https://u.expo.dev/update/:uuid:' \
  -H 'accept: application/expo+json,application/json' \
  -H 'accept-encoding: gzip' \
  -H 'connection: Keep-Alive' \
  -H 'expo-dev-client-id: :uuid:' \
  -H 'expo-platform: android' \
  -H 'host: u.expo.dev' \
  -H 'user-agent: okhttp/4.11.0' \
  --compressed

so somehow during the upgrade path I lost relevant headers?..