Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDK should use isDebugEnabledField instead of BuildConfig.DEBUG #1238

Open
5 tasks done
marcin-adamczewski opened this issue Mar 26, 2024 · 0 comments
Open
5 tasks done

Comments

@marcin-adamczewski
Copy link

Checklist before submitting a bug report

Java version

irrelevant

Android version

irrelevant

Android SDK version

irrelevant - exists on latest main branch

Installation platform & version

Gradle

Package

Core & AppEvents

Goals

AppEventUtility uses BuildConfig.DEBUG, which always returns false as you also claim in troubleshooting here
https://developers.facebook.com/docs/android/troubleshooting/#faq_491357261067442
This code and probably other places in SDK should use FacebookSdk.isDebugEnabledField flag.

For example
AppEventsLogger.clearUserID() should not be called on the main thread as it calls assertIsNotMainThread() inside. Because of this bug, developer doesn't know about it as the app wouldn't crash in debug mode and because this is not documented.

Expected results

Replace BuildConfig.DEBUG with FacebookSdk.isDebugEnabledField

Actual results

App didn't crash in debug, while it should

Steps to reproduce

No response

Code samples & details

// INSERT YOUR CODE HERE
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant