Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Memory Leak #113

Open
QiAnXinCodeSafe opened this issue Jan 16, 2020 · 0 comments
Open

Memory Leak #113

QiAnXinCodeSafe opened this issue Jan 16, 2020 · 0 comments

Comments

@QiAnXinCodeSafe
Copy link

Memory is allocated

openbmc/common/recipes-utils/cpldupdate/files/ispvm_ui.c

Line 296 in 9d57980

g_pucInData = ( unsigned char * ) malloc( usSize / 8 + 2 );

but at the end of function，never free it
facebook-github-bot pushed a commit that referenced this issue Nov 20, 2020
@joancaneus @facebook-github-bot
ELBERT: Use pim eeprom as presence detection source (#113)
59109c1 
Summary:
NOTE: Please merge facebookexternal/openbmc.arista#112 first as this depends on that change

Sometimes, CMB cpld will erroneously report PIM as not inserted even
though it is present but may have corrupted fpga. Add pim smbus eeprom
detection as another source of presence detection.

```Testing:

------PIM-FPGA------
PIM 2: 7.3
PIM 3: 6.4
PIM 4: 7.3
PIM 5: 7.3
PIM 6: 6.4
PIM 7: 6.4
PIM 8: 6.4
PIM 9: 6.4

dpm_ver.sh
PIM2.: SFT013860103
PIM3.: SFT012990103
PIM4.: SFT013860103
PIM5.: SFT013860103
PIM6.: SFT012990103
PIM7.: SFT012990103
PIM8.: SFT012990103
PIM9.: SFT012990103

root@bmc-oob:~# pim_types.sh
PIM 2: PIM8DDM
PIM 3: PIM16Q
PIM 4: PIM8DDM
PIM 5: PIM8DDM
PIM 6: PIM16Q
PIM 7: PIM16Q
PIM 8: PIM16Q
PIM 9: PIM16Q

Pull Request resolved: facebookexternal/openbmc.arista#113

Reviewed By: mikechoifb

fbshipit-source-id: fed0564419
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@QiAnXinCodeSafe