Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resource leak #117

Open
QiAnXinCodeSafe opened this issue Mar 24, 2020 · 0 comments
Open

Resource leak #117

QiAnXinCodeSafe opened this issue Mar 24, 2020 · 0 comments

Comments

@QiAnXinCodeSafe
Copy link

Stream is opened

openbmc/common/recipes-core/fw-util/files/tpm.cpp

Line 34 in 2e61cd4

fp = fopen(TPM_VERSION_LOCATION, "r");

Opened file never closed

openbmc/common/recipes-core/fw-util/files/tpm.cpp

Line 44 in 2e61cd4

return -1;

@leilanon leilanon mentioned this issue Apr 17, 2020
Closed
facebook-github-bot pushed a commit that referenced this issue May 26, 2020
@facebook-github-bot
fixes issue #110 (#119)
40bb49e 
Summary:
Fixes #110 Solution: Add print limitation.

#114 #116 #117  Seems to be false alarms.
However there is a possible memory leak in
https://github.com/facebook/openbmc/blob/de522bcdf9ea26e52a81b9a4a69326774bb87a07/common/recipes-core/fw-util/files/tpm2.cpp#L45
Opening pipeline should be closed at the end of process.
Pull Request resolved: #119

Reviewed By: benwei13

Pulled By: williamspatrick

fbshipit-source-id: 6f08ce26f4
facebook-github-bot pushed a commit that referenced this issue Dec 4, 2020
@joancaneus @facebook-github-bot
ELBERT: Add MAX6581 in userspace (#117)
d2ba587 
Summary:
ELBERT: Add MAX6581 in userspace

- Add TH4 Diode temp sensor in setup_i2c.sh instead of dts. This allows
  it to retry adding the device if it fails to probe for any reason.

Testing:

Following tests no longer occasionally fail
- test_i2c
- test_sensor_calibration

Pull Request resolved: facebookexternal/openbmc.arista#117

Reviewed By: tao-ren

fbshipit-source-id: 39d1436ef3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@QiAnXinCodeSafe