Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IRList.structural_equals doesn't handle some instructions #778

Open
fengruisd opened this issue Mar 30, 2023 · 0 comments
Open

IRList.structural_equals doesn't handle some instructions #778

fengruisd opened this issue Mar 30, 2023 · 0 comments

Comments

@fengruisd
Copy link

IRList.structural_equals does not handle MFLOW_FALLTHROUGH and instructions at the end of method.

if there are 2 methods

  • method1's IR:
    return-void
  • method2's IR:
  FALLTHROUGH
  return-void
  FALLTHROUGH or DEBUG or POSITION

the 2 method should be "structural equals", but redex return false, because

  1. structural_equals does not skip FALLTHROUGH
  2. structural_equals does not skip useless instructions at the end of method2, which means that the pointer of method1 reaches the end first, while the pointer of method2 still points to the useless instruction.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant