Skip to content
This repository has been archived by the owner on Jun 10, 2021. It is now read-only.

Extension groups? #55

Open
modocache opened this issue May 21, 2015 · 3 comments
Open

Extension groups? #55

modocache opened this issue May 21, 2015 · 3 comments
Labels

Comments

@modocache
Copy link
Contributor

Sometimes I want to modify all instances of a particular string in an Objective-C/Swift codebase. At Facebook, that means --extensions=h,m,mm,swift,BUCK,plist.

Typing those out is a pain--instead, it might be cool to have "extension groups", or aliases for a list of extensions. For example, if we defined a group called ios, these two would be equivalent:

--extensions=h,m,mm,swift,BUCK,DEFS,plist
--extensions=ios

Since ios means different things to different teams, maybe one should be able to register their own custom groups, instead of codemod making a decision as to what ios means for everyone.

Not sure if this is a good idea, as it might just be adding a complex feature without a great need to--thoughts? 🙌

@ghost
Copy link

ghost commented Aug 4, 2015

Thank you for reporting this issue and appreciate your patience. We've notified the core team for an update on this issue. We're looking for a response within the next 30 days or the issue may be closed.

@keyan keyan added the feature label May 17, 2016
@keyan
Copy link
Contributor

keyan commented Jun 8, 2016

I don't personally have a use for this feature, but I could see it being useful. Overall I think it's too much complexity for a niche use-case. Anyone else think this could be helpful?

@rochacbruno
Copy link
Contributor

To implement that we should add ~/.codemodrc file and

[extension_groups]
ios=h,m,mm,swift,BUCK,DEFS,plist

Not a good idea to hardcode the list

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants