Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing on Chrome, Firefox, and Edge version 100? #567

Closed
jparismorgan opened this issue Feb 17, 2022 · 4 comments
Closed

Testing on Chrome, Firefox, and Edge version 100? #567

jparismorgan opened this issue Feb 17, 2022 · 4 comments

Comments

@jparismorgan
Copy link
Contributor

jparismorgan commented Feb 17, 2022

This article points out concerns about Chrome, Firefox, and Edge hitting version 100 and the impact of that on user agent parsing libraries: https://www.theverge.com/2022/2/17/22938721/chrome-firefox-edge-version-100-websites-bug-compatibility-issues-mozilla-google-microsoft

Has there been testing of ua-parser-js on whether anything will be broken?

@jparismorgan
Copy link
Contributor Author

Ended up testing and things look okay: #568

@faisalman
Copy link
Owner

The bug can be happened when comparing version number using string, like what was once found in slack [1]

if (browser.version > '52')

up until '99' the result would still be TRUE but once the browser is turning '100' it would be FALSE, which is not the intended result.

[1] webcompat/web-bugs#67866

@jparismorgan
Copy link
Contributor Author

jparismorgan commented Feb 27, 2022

Thanks @faisalman, so you can also confirm you believe things will work for version 100? If so please go ahead and close this issue!

Also, calling out a comment on the PR in which I added tests for browser version 100: #568 (comment)

My understanding is this will work until Chrome 107 - https://blog.chromium.org/2021/09/user-agent-reduction-origin-trial-and-dates.html - after that user agent string will be with reduced information and from that point forward folks should rely on navigator.userAgentData ie. the User Agent Client Hints - https://web.dev/user-agent-client-hints/

Feature request for Client Hints -> https://github.com/faisalman/ua-parser-js/issues/408

This already has a general feature request, but given things will break in Chrome 107, I wanted to flag it as particularly concerning.

@faisalman
Copy link
Owner

Closed by #568

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants